Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMSBIOHUB-632: Display Markdown in Vote Dialogs #1418

Merged
merged 14 commits into from
Nov 25, 2024
Merged

SIMSBIOHUB-632: Display Markdown in Vote Dialogs #1418

merged 14 commits into from
Nov 25, 2024

Conversation

mauberti-bc
Copy link
Collaborator

Links to Jira Tickets

Description of Changes

  • Adds markdown table to the database for storing versions of markdown text to be displayed in help dialogs
  • Adds the ability for users to upvote or downvote markdown records in help dialogs
  • Adds help button to each of the main sections in the app (eg. Survey list container, summary data, Survey data, etc.)

Testing Notes

  • A user can only vote once per markdown record

@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.97297% with 40 lines in your changes missing coverage. Please review.

Project coverage is 45.49%. Comparing base (8f48b31) to head (1b59e35).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
app/src/hooks/api/useMarkdownApi.ts 11.11% 8 Missing ⚠️
app/src/components/dialog/ScoreDialog.tsx 22.22% 6 Missing and 1 partial ⚠️
app/src/components/buttons/HelpButtonDialog.tsx 57.14% 6 Missing ⚠️
...pp/src/components/buttons/MarkdownScoreButtons.tsx 20.00% 4 Missing ⚠️
app/src/components/markdown/CustomMarkdown.tsx 0.00% 3 Missing ⚠️
...tures/summary/list-data/ListDataTableContainer.tsx 0.00% 3 Missing ⚠️
api/src/database-models/markdown_type.ts 0.00% 2 Missing ⚠️
api/src/paths/markdown/index.ts 96.00% 1 Missing ⚠️
api/src/paths/markdown/{markdownId}/index.ts 96.29% 1 Missing ⚠️
api/src/repositories/markdown-repository.ts 94.11% 0 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1418      +/-   ##
==========================================
+ Coverage   45.30%   45.49%   +0.19%     
==========================================
  Files         828      842      +14     
  Lines       22111    22254     +143     
  Branches     3290     3301      +11     
==========================================
+ Hits        10017    10125     +108     
- Misses      11499    11532      +33     
- Partials      595      597       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc mauberti-bc marked this pull request as ready for review November 5, 2024 19:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Openshift URLs for the PR Deployment:

@NickPhura NickPhura marked this pull request as draft November 8, 2024 17:17
@NickPhura
Copy link
Collaborator

Converting to draft temporarily to save Openshift resources.

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Nov 15, 2024
@mauberti-bc mauberti-bc marked this pull request as ready for review November 15, 2024 21:08
@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

NickPhura
NickPhura previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👎

NickPhura
NickPhura approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@NickPhura NickPhura merged commit 0a9a57f into dev Nov 25, 2024
23 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-632 branch November 25, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickPhura NickPhura NickPhura approved these changes

Assignees
No one assigned
Labels
Ready For Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauberti-bc @NickPhura